pagination and linking improvements

src/web-client/src/routes/+layout.svelte

@@ -1,6 +1,6 @@
 <script lang="ts">
 	import type { LayoutData } from './$types';
-	import { goto, invalidateAll } from '$app/navigation';
+	import { goto } from '$app/navigation';
 	import SearchBox from '$lib/SearchBox.svelte';
 	import '../app.css';
 
@@ -40,7 +40,7 @@
 		<ul class="flex w-full py-3 items-center justify-between">
 			<li class="flex grow justify-center">
 				<span class="flex grow" style="max-width: 75%;">
-					<SearchBox on:search={onSubmit} page={data.page} />
+					<SearchBox on:search={onSubmit} query={data.query} page={data.page} />
 				</span>
 			</li>
 			<li class="px-6">

src/web-client/src/routes/+page.svelte

@@ -5,10 +5,17 @@
 
 	export let data: PageData;
 
+	function buildQueryString({ query, page }: { query: string; page: number }): string {
+		const qs = [query === '' ? query : `query=${query}`, page <= 1 ? '' : `page=${page}`]
+			.filter((x) => x !== '')
+			.join('&');
+
+		return qs !== '' ? `?${qs}` : qs;
+	}
+
 	$: hasResults = (data.results || []).length > 0;
 	$: currentPage = data.page + 1;
-	$: pageCount = Math.max(1, Math.floor(data.found / data.limit));
-	$: console.log(data.found, ' / ', data.limit, ' = ', data.found / data.limit);
+	$: pageCount = Math.max(1, Math.ceil(data.found / data.limit));
 </script>
 
 {#if hasResults}
@@ -17,7 +24,9 @@
 		<ol class="flex justify-between w-full center" style="padding: 0 10%;">
 			{#if currentPage > 1}
 				<li in:fade>
-					<a href="/?query={data.query}&page={data.page - 1}">&lt;Previous</a>
+					<a href="/{buildQueryString({ query: data.query, page: currentPage - 1 })}"
+						>&lt;Previous</a
+					>
 				</li>
 			{:else}
 				<li />
@@ -25,7 +34,7 @@
 			<li>Page {currentPage} of {pageCount}</li>
 			{#if currentPage < pageCount}
 				<li in:fade>
-					<a href="/?query={data.query}&page={data.page + 1}">Next&gt;</a>
+					<a href="/{buildQueryString({ query: data.query, page: currentPage + 1 })}">Next&gt;</a>
 				</li>
 			{/if}
 		</ol>

src/web-client/src/routes/+page.ts

@@ -14,20 +14,19 @@ interface SearchPageData {
 }
 
 export const load = (async ({ fetch, url }): Promise<SearchPageData> => {
-	// TODO: refactor to one source of truth for all query param value fetching
-	const searchTerm = url.searchParams.get('query') || '';
-	const currentPage = Number(url.searchParams.get('page') || 0);
-	const currentLimit = Number(url.searchParams.get('limit') || 64);
+	const searchParams = new SearchParameters(url);
+	const limit = searchParams.getLimit();
+	const searchTerm = searchParams.getSearchTerm();
 
 	try {
 		// TODO: refactor to one source of truth for all query string building
-		const response = await fetch(API_HOST + `/upcoming?searchTerm=${searchTerm}&page=${currentPage}&limit=${currentLimit}`);
+		const response = await fetch(API_HOST + `/upcoming${searchParams.toQueryString()}`);
 		const { page, total, found, results } = await response.json() || {};
 
 		// TODO: return found results so we can do upperbound on pagination
 		return {
 			page,
-			limit: currentLimit,
+			limit,
 			query: searchTerm,
 			found,
 			total,
@@ -37,7 +36,7 @@ export const load = (async ({ fetch, url }): Promise<SearchPageData> => {
 		console.log(e);
 		return {
 			page: 0,
-			limit: currentLimit,
+			limit,
 			query: searchTerm,
 			found: 0,
 			total: 0,
@@ -46,3 +45,41 @@ export const load = (async ({ fetch, url }): Promise<SearchPageData> => {
 	}
 
 }) satisfies PageLoad;
+
+class SearchParameters {
+	page: number
+	limit: number
+	searchTerm?: string
+
+	constructor(url: URL) {
+		this.searchTerm = url.searchParams.get('query') || undefined;
+		this.page = Number(url.searchParams.get('page') || 1) - 1;
+		if (this.page < 0 ) {
+			this.page = 0;
+		}
+
+		this.limit = Number(url.searchParams.get('limit') || 64);
+		if (this.limit > 128) {
+			this.limit = 128;
+		} else if (this.limit < 32) {
+			this.limit = 32;
+		}
+	}
+
+	getPage(): number {
+		return this.page || 0;
+	}
+
+	getSearchTerm(): string {
+		return this.searchTerm || '';
+	}
+
+	getLimit(): number {
+		return this.limit || 64;
+	}
+
+	toQueryString(): string {
+		const qs = Object.entries(this).filter(t => t.length > 0 && t[1]).map(t => `${t[0]}=${t[1]}`).join('&');
+		return qs === '' ? '' : `?${qs}`;
+	}
+}